Nat Pryce comments

Results 55 comments of


                                            Nat Pryce

unknown CPU type: armv6l

What machine are you running configure on? On Wednesday, 7 October 2015, Sebastian Blei [email protected] wrote: > Hello there, > > If I run configure in rust directory, I get...

"Compiling the compiler" suggestion

This is caused by a recent change in the way the rust compiler works, and I've not updated my instructions to cope with it. I'll update my copy of rustc...

ExpectedException#expect() should take Matcher<? extends Throwable> as its argument

This is definitely an improvement. The problem with instanceof and not(instanceof(...)) is that instanceof has the wrong signature, which will be fixed in Hamcrest eventually

Declare runtime dependency on JUnit and Hamcrest, not compile dependency

You are not meant to use hamcrest-junit by itself. The intended use is to allow JUnit to be used with the latest versions of Hamcrest. So, in your project, depend...

Support indexed getters (gettters with single argument)

Once is no problem. After repeating the same pattern of code for indexed properties of different types in several tests, I thought it would be worth supporting directly in the...

Support indexed getters (gettters with single argument)

Implementation in pull request #3

Formatter should define file extension

I think you're assuming that the SourceOfApproval will take a file extension as a constructor parameter and hold it in a field. I think it should take a file extension...

Formatter should define file extension

I can see where the Approver can pass the file extension from the formatter to the SourceOfApproval. But it would create a lot of duplication. It feels as if the...

Domain-specific Matchers factory classes

See the discussion with Colin Vipurs on the Hamcrest Java mailing list about how to better aid IDE autocomplete: https://groups.google.com/d/msg/hamcrest-java/0x6brgczThc/lF8LDTaneBoJ

Domain-specific Matchers factory classes

Yes. After using the MatchXxx convention a bit I do find that autocomplete brings in too many unrelated suggestions. MatchingXxx would filter them out.