types icon indicating copy to clipboard operation
types copied to clipboard

chore: release 2.0.0

Open github-actions[bot] opened this issue 1 year ago • 1 comments

:robot: I have created a release beep boop

2.0.0 (2024-05-08)

⚠️ BREAKING CHANGES

  • update types (#29)
  • refactor to use @npmcli/template-oss (#31)

Features

  • 123bb67 #29 update types (#29) (@broofa, @jablko, @lukekarrys)
  • f09f754 #31 refactor to use @npmcli/template-oss (#31) (@lukekarrys)

Bug Fixes

Documentation

  • 5511d4b #40 fix README typo, improve PackageJSON description (#40) (@broofa, @styfle)
  • 1a08144 #37 fix typo in readme (#37) (@lukekarrys)

Chores

  • 3687a18 #38 simplify template-oss config (#38) (@lukekarrys)
  • 1a1fd85 #36 remove build script and update snapshots and tsconfig (#36) (@lukekarrys)
  • 3172a32 update template-oss files for main branch (@lukekarrys)

This PR was generated with Release Please. See documentation.

github-actions[bot] avatar May 06 '24 23:05 github-actions[bot]

Release Manager

Release workflow run: https://github.com/npm/types/actions/runs/10287069984

Release Checklist for v2.0.0

  • [x] 1. Approve this PR

    gh pr review 34 -R npm/types --approve
    
  • [x] 2. Merge release PR :rotating_light: Merging this will auto publish :rotating_light:

    gh pr merge 34 -R npm/types --squash
    
  • [ ] 3. Check For Release Tags

    Release Please will run on the just pushed release commit and create GitHub releases and tags for each package.

    gh run watch -R npm/types $(gh run list -R npm/types -w release -b main -L 1 --json databaseId -q ".[0].databaseId")
    

github-actions[bot] avatar May 06 '24 23:05 github-actions[bot]

@lukekarrys Any word on when this will be published?

broofa avatar Jun 24 '24 13:06 broofa

@broofa I'm no longer a member of the npm team so I won't be able to publish this. Hopefully someone on @npm/cli-team can help out.

lukekarrys avatar Jul 16 '24 23:07 lukekarrys

@lukekarrys : Any idea who, specifically, I can ping about this? This is so close. Literally all that's left is for someone to click the damn "merge" button, no?

My unprofessional reaction aside, thanks for all your work on this. Hopefully you've moved on to something newer and interesting-er!

broofa avatar Jul 17 '24 00:07 broofa

@GrantBirki @arisacoba @dhei @dylanatsmith @feelepxyz @joseph-lozano @joshspicer @jumoel @leobalter @monishcm @mrecachinas @MylesBorins @navin22 @nishantms @pwelch @reggi @saquibkhan @shmam @steiza @strackoverflow @tayvon @tiagonbotelho @trevrosen @vcsjones @wraithgar @xodene

My sincere apologies for the "@"-spam here, but this situation is a bit frustrating. Briefly...

  • I've been working with @lukekarrys to bring much-needed updates to this project. This has involved a non-trivial amount of work that, personally, I'm pretty proud of. It is a tangible improvement that many people in the community should find useful. This was completed and merged 2+ months ago in #29.
  • That work should have been released as @npm/[email protected] (this PR)... but for whatever reason that never happened.
  • And now, with @lukekarrys moving on it's unclear who, if anybody, is in a position to actually move this PR forward.

So my immediate ask is this: Please help me identify someone who can merge and publish this PR

If that happens to be one of you folks...

  • [x] Please merge #60 first (minor, nice-to-have updates that should go out with this release)
  • [ ] Merge and approve this PR (thus, causing 2.0.0 to be published)

That's it. That's all I need.

Again, my apologies for the spam.

broofa avatar Jul 19 '24 13:07 broofa

Hi @broofa you might have missed including me on the cc list.

I'm coordinating with the npm team how we best continue here both on the release and the follow up changes you mentioned.

While I'm writing this, it seems @reggi is already self assigning here and so I'm optimistic to see this resolved soon!

leobalter avatar Jul 19 '24 13:07 leobalter

There was one technical hang-up on getting this published, which is why I wasn't able to merge this PR previously.

@reggi Even though the Release Manager issue says otherwise, merging this PR won't actually publish it since I never got around to creating a publish token for @npm/types. There was concern that the @npm scope was not the correct place to publish this anymore since that scope is mostly reserved for internal packages. I thought about changing it to @npm-cli but then the name would be @npm-cli/types which would be pretty confusing imo.

This is just to give context around why it hasn't been published yet. The solution will be to create a publish token for whatever the name ends up being (even if it stays as @npm/types) and adding it as a repo secret and then merging this PR.

lukekarrys avatar Jul 19 '24 16:07 lukekarrys

:robot: Release is at https://github.com/npm/types/releases/tag/v2.0.0 :sunflower:

github-actions[bot] avatar Aug 13 '24 16:08 github-actions[bot]

Release Workflow

  • @npm/[email protected] https://github.com/npm/types/releases/tag/v2.0.0
  • Workflow run: :white_check_mark: https://github.com/npm/types/actions/runs/10373603885

:rotating_light::rotating_light::rotating_light:

@npm/cli-team: The post-release workflow failed for this release. Manual steps may need to be taken after examining the workflow output.

:rotating_light::rotating_light::rotating_light:

github-actions[bot] avatar Aug 13 '24 16:08 github-actions[bot]

It looks like 2.0.0 is up on NPM. Huzzah! Thanks for making this happen!

broofa avatar Aug 13 '24 16:08 broofa