tink icon indicating copy to clipboard operation
tink copied to clipboard

Published 20 hours ago • verified publisher icon npm

feat(view): add PackageSummary

Open larsgw opened this issue 6 years ago • 6 comments

Add a PackageSummary for a consistent 3-line information-dense summary of a package. With Box:

screenshot_20181130_211655

Without (not possible currently, I didn't include it due to the way it looks with other content around it):

screenshot_20181130_211834

Some TODOs:

  • [x] Description and keywords should be cut off if too long (we don't want extra lines)
  • [x] ~~I think the other thing was "wrap lines if too long", but that's completely contradictory, so scratch that~~

See https://github.com/npm/tink/pull/11#issuecomment-440055235 (@chrisforrette)

larsgw avatar Nov 30 '18 20:11 larsgw

This looks great! Happy to merge this pending @chrisforrette's comments and the rest of your TODO 👍

zkat avatar Jan 03 '19 19:01 zkat

I added a PackageSearchResult and a fix for the TODO.

larsgw avatar Jan 03 '19 23:01 larsgw

@larsgw Hey there, I'm waiting on this to land to wrap up #11. Aside from fixing the build and updating from master are there any other hold-ups to merging this?

chrisforrette avatar Jan 31 '19 18:01 chrisforrette

@chrisforrette right, I didn't notice this wasn't working

larsgw avatar Jan 31 '19 19:01 larsgw

@zkat do I need to do anything else before merge?

larsgw avatar Jan 31 '19 19:01 larsgw

@zkat Hey Kat! Can we merge this thinger?

chrisforrette avatar Feb 28 '19 08:02 chrisforrette