statusboard icon indicating copy to clipboard operation
statusboard copied to clipboard

chore(CI): investigate windows workflows vs real world usage

Open lukekarrys opened this issue 3 years ago • 0 comments

We currently run tests with the following workflow settings for Windows:

os: windows-latest
shell: cmd

Something I didn't realize is that the windows-2022 runner image ships with Bash 5.1.16(1)-release. Ref: actions/runner-images.

This caused unexpected behavior when trying to setup my windows dev environent because I was mistakenly trying to run everything with cmd.exe without bash installed. And things like touch prepack which we run in tests worked in CI but on my my machine. Ref: https://github.com/npm/cli/blob/f0e758494698d9dd8a58d07bf71c87608c36869e/workspaces/libnpmpack/test/index.js#L40-L41

Exit Criteria:

  • [ ] Create contributing guide for windows
    • [ ] Including either a guide to settings for autocrlf or having template-oss create a gitattributes file
  • [ ] Audit windows CI setup to ensure it matches real world usage and what we want to test

lukekarrys avatar Sep 29 '22 21:09 lukekarrys