npm-expansions icon indicating copy to clipboard operation
npm-expansions copied to clipboard

[BUG] This repo is never checked

Open YodaLightsabr opened this issue 3 years ago • 29 comments

What / Why

This repo has not been modified since July of last year (#3488), despite the hundreds of pull requests.

When

  • Whenever I click on the Pull requests, I see hundreds of pull requests that are open and neglected.
  • Every day many new pull requests are created and ignored

Where

  • The pull requests tab

How

Current Behavior

  • Pull requests are neglected

Steps to Reproduce

  • Make a pull request
  • Wait a few months

Expected Behavior

  • Make a pull request
  • Wait a few days

Who

  • The NPM team

References

  • Related to every pull request that is open

YodaLightsabr avatar Jan 21 '22 18:01 YodaLightsabr

bug lol

Explosion-Scratch avatar Jan 21 '22 20:01 Explosion-Scratch

Tbh, it bugs me

YodaLightsabr avatar Jan 24 '22 15:01 YodaLightsabr

Npm busy with tryina fight yarn xD

ghost avatar Feb 10 '22 02:02 ghost

I'm very tempted to reference every open pull request under the references section. All of the open pull requests referenced in an image

YodaLightsabr avatar Feb 10 '22 04:02 YodaLightsabr

image

Explosion-Scratch avatar Feb 10 '22 13:02 Explosion-Scratch

:fire: March 2022 hot update :fire:

  • Number of pull requests :arrow_up:
  • Number of merges :zero:

TheDechev avatar Mar 27 '22 17:03 TheDechev

Npm busy with tryina fight yarn xD

and pnpm

Explosion-Scratch avatar Mar 27 '22 17:03 Explosion-Scratch

xD

ghost avatar Mar 27 '22 19:03 ghost

Eyy, this is a good one! This will definitely be added no way sirree will be this be ignored (waits for the rest of their life for nothing)

a-a-GiTHuB-a-a avatar Apr 28 '22 23:04 a-a-GiTHuB-a-a

Eyy, a good one! This will definitely be added no way sirree will be this be ignored (waits like a year)

xD I quit using nodejs and started using java... and bro I have to tell you.. the performance was amazing!!!! don't listen to those people who lie about java being "slow" it ran so fast that I crashed my PC with a loop. because the threads run very fast and yea... it means its not limited like java xD

ghost avatar Apr 30 '22 16:04 ghost

You just said "java is not limited like java" WHAT!?

a-a-GiTHuB-a-a avatar Apr 30 '22 17:04 a-a-GiTHuB-a-a

oops java is not limited like javascript

ghost avatar May 01 '22 13:05 ghost

does anyone have discord xD this issue has gotten pretty off topic I actually don't even think NPM willever take this issue into consideration

ghost avatar May 01 '22 13:05 ghost

I don't expect them to, I just thought this would be funny for people to stumble across. Also, quick poll (👍 / 👎): should I add every open pull request to the references section?

YodaLightsabr avatar May 01 '22 18:05 YodaLightsabr

im just gona follow everyone involved in this post and hope to make some friends xD

ghost avatar May 01 '22 23:05 ghost

Eyy, a good one! This will definitely be added no way sirree will be this be ignored (waits like a year)

I added a PR with 47 new NPM ideas and was feeling good about that till I saw the number of open PRs. D:

akcumeh avatar Aug 30 '22 11:08 akcumeh

Eyy, a good one! This will definitely be added no way sirree will be this be ignored (waits like a year)

xD I quit using nodejs and started using java... and bro I have to tell you.. the performance was amazing!!!! don't listen to those people who lie about java being "slow" it ran so fast that I crashed my PC with a loop. because the threads run very fast and yea... it means its not limited like java xD

Java is compiled into a native executable. Javascript is interpreted with one. That means JS is inherently slower. It's more feature-dense, though, and no compilation step is needed.

a-a-GiTHuB-a-a avatar Aug 30 '22 13:08 a-a-GiTHuB-a-a

tf, java is NOT compiled to native. Also im now a C++ dev XDDDD super painful to use but Im good with it. also Java is rediculously slower compared to nodejs since it does not have JIT

ghost avatar Aug 30 '22 23:08 ghost

yo any of u guys got Discord? at this point NPM clearly doesnt care about US THE POEPLE lmao

ghost avatar Aug 30 '22 23:08 ghost

They probably even forgot existence of this repo or something, anyways if they don't care about the repo it would be better idea to archive it I believe, there is already a ton of fun messages.

ghost avatar Sep 02 '22 23:09 ghost

they should make a bot to do this so they can tell yarn is not better than npm

amol234545 avatar Nov 23 '22 02:11 amol234545

Hundreds? Try thousands.

a-a-GiTHuB-a-a avatar Dec 30 '22 15:12 a-a-GiTHuB-a-a

Npm busy with tryina fight yarn xD

and pnpm It literally has npm in it's name

amol234545 avatar Dec 30 '22 16:12 amol234545

since it does not have JIT

V8 does do partial JIT compilation too...

GoldenretriverYT avatar Feb 28 '23 13:02 GoldenretriverYT

What is JIT, and why is it important?

a-a-GiTHuB-a-a avatar Feb 28 '23 14:02 a-a-GiTHuB-a-a

Replying to @a-a-GiTHuB-a-a:

What is JIT, and why is it important?

JIT stands for Just-In-Time Compilation. It is basically an approach to code execution used by, for instance, the V8 engine upon which Node.js and Chromium rely to execute JavaScript. Here, code is translated to executable format, then run in parallel as it's being read. This gives us the advantages of compiled-like speed and interpreted-like developer experience.

santi100a avatar Sep 20 '23 23:09 santi100a

Wait...... I should've realize this when I noticed the last edit time on expansions.txt...... So dump of me to send so many pull requests just thinking it's fun......

X-Engineer-001 avatar Jan 04 '24 03:01 X-Engineer-001

The big problem with merging the 99999999 PRs is that each time, the NPM devs have to sort the answers (since the new expansions may conflict in position), which gets tedious.

a-a-GiTHuB-a-a avatar Jan 04 '24 13:01 a-a-GiTHuB-a-a

@a-a-GiTHuB-a-a don't be ridiculous. They could easily just have a pre-commit hook sort the list for them. The only and real reason is that this is extremely low priority and the key holder already has enough.

Honestly, with these fluff pet repos, you make it a small event if you want it getting attention at all. I'd have made it a team exercise to have everyone who works for npm, Inc take five minutes and choose a PR to merge on the day of the library's anniversary. That gives everyone some coffee talk too.

up201306506 avatar Feb 23 '24 08:02 up201306506