normalize-package-data icon indicating copy to clipboard operation
normalize-package-data copied to clipboard

[QUESTION] Does original code accept empty name and/or version string?

Open myrne opened this issue 11 years ago • 0 comments

Original code:

function validName (file, data) {
                if (!data.name) {
                                data.name = ""
                                return true
                }
// some more stuff
}

Perhaps in the whole npm flow, name and version are checked somewhere else as well. But as stand-alone module, I think it'd be better to throw here as well.

myrne avatar Apr 08 '13 18:04 myrne