marky-markdown icon indicating copy to clipboard operation
marky-markdown copied to clipboard

image src is parsed error

Open hiowenluke opened this issue 8 years ago • 3 comments

The following code:

<a href='https://github.com/tasjs/fac' target='_blank'> <img width='150' src='./res/logo_icon_150.png' /><br /> <img height='60' src='./res/slogan.png' /> </a>

the 1st src is correctly parsed, see: https://github.com/tasjs/fac . but the 2nd src is not (the image is not shown), see: https://www.npmjs.com/package/fac .

hiowenluke avatar Oct 02 '17 17:10 hiowenluke

Interesting, @hiowenluke, thanks for the report! I see it in the generated markup on the npm site, but the path to the PNG file hasn't been rewritten to the GitHub URL for some reason. I guess that's where we'll have to start investigating...

revin avatar Oct 05 '17 17:10 revin

How typical. This was a mistake on my end. 🙄 Submitted a PR.

revin avatar Oct 06 '17 21:10 revin

That's great! Thank you @revin .

hiowenluke avatar Oct 07 '17 02:10 hiowenluke