marky-markdown icon indicating copy to clipboard operation
marky-markdown copied to clipboard

[WIP] separate packagize code into separate dep, pkgize

Open ashleygwilliams opened this issue 9 years ago • 4 comments

fixes #257

pulls packagize code into it's own pkg, pkgize: https://www.npmjs.com/package/pkgize

had to pull token-util into pkgize... should we make that it's own separate pkg? i dont like the repeated code but also don't know if we'll even save pkgize so maybe it doesn't matter?

ashleygwilliams avatar Oct 31 '16 19:10 ashleygwilliams

@ashleygwilliams Can you please remind me of the reasoning behind this, again? Is it to keep the "npm-ish" stuff out of marky so marky can stick to being a GitHub-style markdown parser? If so, do you think cdn.js should be extracted as well?

revin avatar Nov 01 '16 14:11 revin

oh, also re: token-util, it turns out the one function pkgize needs is getText, and no other code in marky needs it, so you should be able to just move getText all by itself without issue.

revin avatar Nov 01 '16 14:11 revin

@revin - exactly. i'd like marky to be just a GFM parser, and right now it's doing some other stuff. in the long run- i'm not sure the website wants it to do this stuff and so in preparation, i'm separating it out. i think ideally it's code that we can just get rid of all together.

ashleygwilliams avatar Nov 01 '16 16:11 ashleygwilliams

this is waiting on me moving over the tests. also needs a rebase as this point.

ashleygwilliams avatar Nov 20 '16 20:11 ashleygwilliams