map-workspaces icon indicating copy to clipboard operation
map-workspaces copied to clipboard

fix: Update `engines` to handle `node:` prefix

Open hashtagchris opened this issue 7 months ago • 1 comments

Description

If you install the latest versions of this package's dependencies, node 14.17.x no longer works due to a node: prefix being added in https://github.com/isaacs/node-glob/commit/435d1f7acd78a00c9dab2a7f6489155c7caac97c. node: import support was added to node 14.18.0 (ref).

I'd prefer to fix the build break for the current major version of this package, before we release a new major version. The options I see are:

  1. Pin to [email protected] to get node 14.17.x working again. However we'll lose the fix for https://github.com/isaacs/node-glob/issues/584. And there probably wouldn't be a simple path for 14.latest consumers to get that fix back, as we might drop node 14 in the next major version.
  2. Update engines to reflect reality, without changing the major version.
  3. Do nothing with regards to the current major version.

I went with Option 2. If this package still has node 14 consumers, I'm hoping they're using 14.latest or can move to ^14.18.0.

If we agree on this path forward, I intend to apply the same change to several other npm-cli repos using glob@10.

hashtagchris avatar Jul 26 '24 13:07 hashtagchris