map-workspaces icon indicating copy to clipboard operation
map-workspaces copied to clipboard

fix!: Address breaking engine change in dependency

Open hashtagchris opened this issue 7 months ago • 0 comments

Description

Remove Node 14 from engines. node 14.17.x no longer works due to https://github.com/isaacs/node-glob/commit/435d1f7acd78a00c9dab2a7f6489155c7caac97c. If this change is approved, I intend to apply the same change to other npm-cli repos that use glob@10.

Alternative solutions:

  • Increase the min engine version for Node 14 to ^14.18.0. In the past this has been considered a breaking change, and requires increase of the major version. However engines is already inaccurate if you install the latest version of glob@10. 🤔
  • Pin to [email protected] to keep node 14.17.x working. However we'll lose the fix for https://github.com/isaacs/node-glob/issues/584

Discovered via the CI for https://github.com/npm/map-workspaces/pull/162

hashtagchris avatar Jul 26 '24 03:07 hashtagchris