hosted-git-info icon indicating copy to clipboard operation
hosted-git-info copied to clipboard

fix: update the path to the GitLab-hosted archive

Open zkochan opened this issue 2 years ago • 2 comments

References

Related to https://github.com/pnpm/pnpm/issues/3643

zkochan avatar Sep 04 '21 23:09 zkochan

If I go to a gitlab repo and find the archive url it's formatted like this https://gitlab.com/gitlab-org/gitlab-foss/-/archive/master/gitlab-foss-master.tar.gz, which works without authorization (as i would expect because it's public)

If I format that url through the /api/v4/ I get a 302 response. Are we sure the api url is what we want to use here?

wraithgar avatar Jan 05 '22 18:01 wraithgar

@wraithgar I also came to the same conclusion when triagging this one: https://github.com/npm/cli/issues/3359#issuecomment-1058455507

ruyadorno avatar Mar 03 '22 20:03 ruyadorno

i'm going to close this issue due to its age, and the appearance that the change here is not something that we want due to the change in responses

nlf avatar Apr 17 '23 19:04 nlf