fstream-ignore icon indicating copy to clipboard operation
fstream-ignore copied to clipboard

Published 20 hours ago • verified publisher icon npm

So this should work but it doesn't

Open indexzero opened this issue 12 years ago • 3 comments

Should fix #4, but I can't seem to get the tests to pass. I'm unsure if this is a bug in the way I implemented it, or a bug in the tests.

@isaacs can you point me in the right direction?

indexzero avatar Jan 08 '13 00:01 indexzero

Sorry we left this sitting so long; I'll take a look at freshening and landing it (finally).

othiym23 avatar Dec 05 '14 22:12 othiym23

Wow, forgot this even existed. Thanks, now if I could only remember where I worked around this >_<

indexzero avatar Dec 05 '14 22:12 indexzero

I think that the test is at fault: the rules are applied in the order in which they were added. So because the negated rule is added first (in the constructor), and then the rules from the .ignore file are added, the !/c/b/a/cba rule is ignored completely, as there is * afterwards.

I suggest creating a separate test altogether or at least swapping * and !/c/b/a/cba - then the * rule would be first, and negations would come afterwards, being read from the .ignore file.

fatfisz avatar Sep 23 '15 11:09 fatfisz