concurrent-couch-follower icon indicating copy to clipboard operation
concurrent-couch-follower copied to clipboard

Fixes npm/concurrent-couch-follower#2

Open marob opened this issue 9 years ago • 5 comments

This is a Proof Of Concept. While it seems to fix the issue according to my tests, I'm not very proud of the quality of the code. I'm sure there is a better way to handle the issue, but I'm no expert on node streams.

marob avatar Jul 13 '16 15:07 marob

thanks! ill take a look

soldair avatar Jul 13 '16 21:07 soldair

lets figure out a way to write a test for this. but it looks good =)

soldair avatar Jul 13 '16 21:07 soldair

Here is a test.

N.B.: in an ideal world, your tests should not depend on skimdb.npmjs.com

marob avatar Jul 15 '16 13:07 marob

Does this needs to be merged @soldair?

vvo avatar Dec 17 '16 14:12 vvo

I need to test it more myself let me know if you try it out @vvo

We have not run into this issue ourselves yet but i should get to looking at it in January

soldair avatar Dec 18 '16 18:12 soldair