Fix quotes on windows cmd shims

Open connorjsmith opened this issue 6 years ago • 4 comments

Resolves #41 by only using quotes around the node executable when a non-local node binary is used.

Oct 04 '19 04:10 connorjsmith

Hi, I haven't forgotten about this, just running out of time for the 6.12 release, and didn't make it to giving this one the attention it needs.

We'll probably get it (or something like it, if there's issues) in 6.12.1. Sorry for the delay, and thanks for your patience :)

Oct 08 '19 00:10 isaacs

Dec 07 '19 14:12 fengmk2

@isaacs any idea if we can get this in to the next release of npm?

Dec 11 '19 23:12 connorjsmith

First, this needs to be rebased onto the latest master branch.

But more importantly, won't this break if %prog% or %dp0 contain spaces or \ characters? Or am I reading it wrong?

Feb 05 '21 20:02 isaacs