cli icon indicating copy to clipboard operation
cli copied to clipboard

fix(arborist): check placed node children for missing deps (#7746)

Open TrevorBurnham opened this issue 1 year ago • 0 comments

This addresses an edge case where a dep could be placed in the tree with unsatisfied indirect dependencies (see test case), by adding the children of placed deps to the #depsQueue.

See #7746 for details on this bug. As far as I know, this situation only occurs if the lockfile has been manipulated outside of npm; even so, I believe it's worth addressing within npm in order to ensure that the state of the lockfile is consistent (i.e. running npm install more than once does not change the result).

This is my first time working with the npm codebase. I'd welcome any suggestions!

References

Fixes #7746

TrevorBurnham avatar Aug 25 '24 22:08 TrevorBurnham