packetdrill icon indicating copy to clipboard operation
packetdrill copied to clipboard

release packetdrill

Open ligurio opened this issue 5 years ago • 5 comments

Right now repo contains only source in git and it is not clear how to get a stable version. Please consider publishing packetdrill archives as github releases. See https://help.github.com/en/github/administering-a-repository/creating-releases

ligurio avatar Jan 17 '20 09:01 ligurio

Making releases would add confusion between the official packetdrill repo / releases and what is done in this fork (adding support for FreeBSD, Mac OS X, Solaris, UDP Lite, SCTP).

tuexen avatar Jan 17 '20 13:01 tuexen

Yeah, I know. But you are already forked it and it's anyway confuse users. With releases it would be easy to rely on tool. By the way do you plan to merge your changes to upstream?

// CC: @nealcardwell

ligurio avatar Jan 17 '20 13:01 ligurio

Before forking, I tried to contribute for over a year or so. Since that did not work out and I needed an extended version, I forked. This forking happened before Googles packetdrill sources moved to GitHub.

I would be happy to give up the fork, but adding

  • FreeBSD support
  • MacOS support
  • Solaris support
  • UDPLite support
  • SCTP support

might not of interest to Google and would it not be easy for me to dissect the changes to provide simple patches.

tuexen avatar Jan 17 '20 14:01 tuexen

Yes, I'm afraid I was a bottleneck, due to me not having enough cycles for reviewing and integrating into Google's packetdrill sources. (Packetdrill is not really my "day job', BBR and TCP are...).

neal

On Fri, Jan 17, 2020 at 9:55 AM Michael Tüxen [email protected] wrote:

Before forking, I tried to contribute for over a year or so. Since that did not work out and I needed an extended version, I forked. This forking happened before Googles packetdrill sources moved to GitHub.

I would be happy to give up the fork, but adding

  • FreeBSD support
  • MacOS support
  • Solaris support
  • UDPLite support
  • SCTP support

might not of interest to Google and would it not be easy for me to dissect the changes to provide simple patches.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nplab/packetdrill/issues/147?email_source=notifications&email_token=ACZHSHKZG5YVMVVA7ZX6XDDQ6HBGLA5CNFSM4KIFWRJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJH5UBY#issuecomment-575658503, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZHSHIRRHRQGYSB3KD6YQLQ6HBGLANCNFSM4KIFWRJA .

nealcardwell avatar Jan 17 '20 15:01 nealcardwell

@nealcardwell what about merging these features in the near future? I can help with testing patches.

ligurio avatar Jan 17 '20 15:01 ligurio