efcore.pg
efcore.pg copied to clipboard
Test that BCL Types work with NodaTime plugin activated
Run BuiltInDataTypesNpgsqlTest again with the NodaTime plugin activated to verify that all BCL date/time types are properly supported.
Closes #1490
@roji
Npgsql.EntityFrameworkCore.PostgreSQL.BuiltInDataTypesNpgsqlTest.Object_to_string_conversion
fails on my machine:
Edit: I guess this is because my local Postgres db might use a different culture. Can this be enforced in the test-suite (e.x. by setting the culture when scaffolding the test db)?
@davidroth sorry I haven't been more reactive with all this work, am busy with other stuff... Promise to come back to this in a couple days and push it through for 5.0.
@davidroth am under pretty massive workload at the moment, with the 5.0 release coming up. Is there anything that isn't purely-test related, i.e. are we sure that the actual support works? If this is just about adding tests, we can always do that after 5.0 is released.
@davidroth am under pretty massive workload at the moment, with the 5.0 release coming up. Is there anything that isn't purely-test related, i.e. are we sure that the actual support works? If this is just about adding tests, we can always do that after 5.0 is released.
@roji This MR is only for adding tests. The tests revealed a bug first, which has already been fixed. Beside from that, I am confident, that the current support works as expected.
Thanks @davidroth, I'll look into this once things quiet down a bit.