Niall Gallagher
Niall Gallagher
It targets Java 6, so we can't use default methods I'm afraid :( I use Java 8 personally, but I'd like to keep Java 6 compatibility for other users who...
Hi Knut, Sorry I've been away for a few days, but I got some time just now to look into this in more detail. It's not really an option to...
Hi Knut, Sounds good! Yes the searchTree method could be made public. Or rather, I guess it would be a method similar to it (which perhaps wraps it) but which...
Hi Knut, Yes the public interface RadixTree does not extend PrettyPrintable, so this is not part of the public API (intentionally). PrettyPrintable is indeed only an internal implementation detail. It...
There is already a [forEach(Consumer)](https://docs.oracle.com/javase/8/docs/api/java/lang/Iterable.html#forEach-java.util.function.Consumer-) method, inherited from `java.lang.Iterable`, and it's available when the library is run on Java 8. As I mentioned, the existing methods are widely used, so...
Yes, this is a good point. This is an example of defensive programming to ensure the algorithms didn't violate the constraints! But indeed I think the algorithms are well proven...
@VHarisop Yes that looks good. Could you add a unit test(s), to test the new constructor, and to exercise the new branch? We just need to maintain 100% test coverage...
I just don't think this question has come up before! So I guess a tree like that, would be a combination of the ReversedRadixTree, and the InvertedRadixTree? So - an...
Hi Knut, This is a good question. Currently `Character` is used (IIRC), to simplify the implementation of binary search in nodes, as it is convenient that it implements `java.lang.Comparable`. AFAIK...
Looks like there's some info about HotSpot's elimination of auto-boxing here, in quite a similar scenario: https://tavianator.com/java-autoboxing-performance/ It still needs more investigation though!