PyTreasuryDirect icon indicating copy to clipboard operation
PyTreasuryDirect copied to clipboard

Code quality

Open femtotrader opened this issue 7 years ago • 1 comments

Hello,

maybe you can improve code quality of this package quite easily

  • [ ] PEP8
>flake8 PyTreasuryDirect
PyTreasuryDirect\setup.py:2:1: F401 'os.path' imported but unused
PyTreasuryDirect\setup.py:2:1: F401 'os.walk' imported but unused
PyTreasuryDirect\setup.py:7:13: E251 unexpected spaces around keyword / parameter equals
PyTreasuryDirect\setup.py:7:15: E251 unexpected spaces around keyword / parameter equals
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:4:1: E302 expected 2 blank lines, found 1
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:7:5: E301 expected 1 blank line, found 0
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:10:1: E305 expected 2 blank lines after class or function definition, found 1
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:17:1: E302 expected 2 blank lines, found 1
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:48:80: E501 line too long (81 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:58:80: E501 line too long (115 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:66:9: E722 do not use bare except'
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:72:80: E501 line too long (96 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:76:80: E501 line too long (102 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:80:80: E501 line too long (95 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:82:76: W291 trailing whitespace
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:83:25: W291 trailing whitespace
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:84:80: E501 line too long (135 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:92:80: E501 line too long (110 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:92:111: W291 trailing whitespace
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:101:80: E501 line too long (95 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:127:72: W291 trailing whitespace
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:129:58: W291 trailing whitespace
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:131:80: E501 line too long (120 > 79 characters)
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:135:1: E305 expected 2 blank lines after class or function definition, found 1
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:135:12: E225 missing whitespace around operator
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:137:12: E999 SyntaxError: invalid syntax
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:137:54: W291 trailing whitespace
PyTreasuryDirect\pytreasurydirect\pytreasurydirect.py:145:80: E501 line too long (81 > 79 characters)
PyTreasuryDirect\pytreasurydirect\__init__.py:1:1: F403 'from pytreasurydirect import *' used; unable to detect undefined names
PyTreasuryDirect\pytreasurydirect\__init__.py:1:1: F401 'pytreasurydirect.*' imported but unused
PyTreasuryDirect\pytreasurydirect\__init__.py:1:31: W292 no newline at end of file
  • [ ] Unit tests A very basic test can probably be written to download data

  • [ ] Continuous integration Travis CI https://travis-ci.org/ could help to run automatically unit tests

  • [ ] Python 3 support (see https://github.com/npezolano/PyTreasuryDirect/pull/2 but that's not enough)

femtotrader avatar Jan 18 '18 17:01 femtotrader

Thanks, I haven't touched this project in some time, will add travis shortly, feel free to make more commits.

npezolano avatar Jan 19 '18 02:01 npezolano