Nick Perez

Results 442 comments of Nick Perez

Yea, I think that this is fine to merge in as is. I'll get it in

addAttributes cannot always have the editor instance, because in order to make the editor instance, it needs the attributes to create the schema to create the editor instance. In your...

This is a feature of prosemirror, where if the attributes of nodes are the same it will merge them together. In most cases this is desirable behavior. It would not...

Closing in favor of: https://github.com/ueberdosis/tiptap/pull/5374/files Thanks for your contribution. I needed to make some changes to get the tests to run again, but couldn't push to your branch

Is this still an issue? I think that named & default exports should work fine?

I've found that this happens when the plugin is instantiated twice & not destroyed. The cursor flickers sending awareness updates back & forth between the editor instance that is active...

Resolved with: https://github.com/ueberdosis/tiptap/pull/5161

Hi @Krakaw, really appreciate your contribution here, we've gone ahead and merged some thing that achieves the same sort of thing. Thank you for your PR, it was a good...

The types only apply when you have that extension installed. The type definitely is there: https://github.com/ueberdosis/tiptap/blob/main/packages/extension-bold/src/bold.ts#L27