Anthony Ramine
Anthony Ramine
Btw #142 completely removes `HandshakeError`.
I have written bindings for those in #134.
As a first step, I want to change: ```rust pub enum HandshakeError { /// Setup failed. SetupFailure(ErrorStack), /// The handshake failed. Failure(MidHandshakeSslStream), /// The handshake encountered a `WouldBlock` error midway...
Actually the second way with `HandshakeStream` is more pleasant to use so I'm currently doing that.
For now, it looks like this: https://github.com/cloudflare/boring/compare/master...nox:errors
Actually, I realise now that both ways are bad, because in the end, the implementations of `Read` and `Write` want to return an `io::Error`. I now want to reverse everything...
I was staring at those two snippets thinking this would hinder my plan of making everything be `io::Error`: https://github.com/cloudflare/boring/blob/2667b0fdee830acbfbbf4051fb6933c1f0166895/boring/src/ssl/mod.rs#L3131 https://github.com/cloudflare/boring/blob/2667b0fdee830acbfbbf4051fb6933c1f0166895/boring/src/ssl/mod.rs#L3147 (Note for some reason that both check `WANT_READ` even though...
#142 removes `HandshakeError` and its infamous `SetupFailure` variant.
I think we should keep it because Rust doesn't actually guarantee the various malloc linking shenanigans. I think we should do some changes though: - `Library::get_memory` should go away (it...
+1 for publishing on crates.io, I want to try to use jit.rs in servo/rust-selectors.