git-goggles icon indicating copy to clipboard operation
git-goggles copied to clipboard

Published 20 hours ago • verified publisher icon nowells

Code review should use private data

Open dustin opened this issue 14 years ago • 2 comments

Rather than using tags, I think the code review would be better off having a private set of data within .git that it uses to know what you've done and when.

dustin avatar Jan 19 '10 22:01 dustin

Let me look into this. I know that within my team at PBS we share code reviews across multiple machines (whoever has the projector connected to their machine at the time) so that was the rational behind tags, but I agree that it can get cluttered. Maybe I should add the ability to configure how the review tags get stored?

Thanks! Nowell

nowells avatar Jan 20 '10 02:01 nowells

Configurable might be good. It feels more like a branch than a tag, though, if you have it actually moving along with the code. That might be more acceptable. Tags have this habit of moving around on their own and getting into the way of things.

dustin avatar Jan 20 '10 03:01 dustin