novu icon indicating copy to clipboard operation
novu copied to clipboard

[FEATURE REQUEST] Add button to go from docs.novu.co to novu.co

Open PritamSarbajna opened this issue 2 years ago • 16 comments

describe the issue :

In docs.novu.co there isn't anything which redirect user from docs.novu.co to novu.co

suggestive solution:

  • We can add a button at navbar to novu.co or
  • adding novu.co to the novu logo also solves the problem or
  • We can add something on footer which will redirect user to novu.co

PritamSarbajna avatar Jul 31 '22 17:07 PritamSarbajna

Hi @PritamSarbajna! Thank you so much for the feedback 🙌 This is very helpful!

I like the solution of adding a link to the logo, we can also add the target attribute with the value _blank which allows you to simply open novu.co in a new tab without leaving the documentation page

@scopsy Please tell me what you think about it?

andrewgolovanov avatar Aug 02 '22 22:08 andrewgolovanov

Yeah @andrewgolovanov that'd be great. can you tell me where I can implement this as a button or something or like checkout novu.co so I can contribute to it

PritamSarbajna avatar Aug 03 '22 02:08 PritamSarbajna

Hey @andrewgolovanov @PritamSarbajna I love this idea!

@PritamSarbajna as to your question, docs are managed here, so on another repo (novuhq/novu), I am moving this issue there. As to the question of the logo link change, take a look into docusaurus docs about this here.

@PritamSarbajna should we assigned this to you?

ComBarnea avatar Aug 08 '22 10:08 ComBarnea

@ComBarnea Hey I'd love to do it so yeah assign this to me

PritamSarbajna avatar Aug 09 '22 16:08 PritamSarbajna

@ComBarnea also I have a question so you're saying that I should change the link of the logo to docs.novu.co to novu.co as per docusaurus.io ??

PritamSarbajna avatar Aug 14 '22 18:08 PritamSarbajna

@PritamSarbajna the question is, should we navigate to Novu's docs, or to the main website when clicking on the logo on the top. Originally I thought it should be to Novu's main website, but after looking into other implementations I think we should keep it the way it is.

But add on the footer another link for Home. Screen Shot 2022-08-14 at 21 54 04

What do you think @PritamSarbajna ?

ComBarnea avatar Aug 14 '22 18:08 ComBarnea

Hey @ComBarnea when we click on the logo it takes us to docs.novu.co which I think is correct so let it as it is. We can also add HOME as shown above but wouldn't it be odd like 4 : 3. I'm thinking to add novu.co in the footer's novu logo but the question is how will users know that if we click on that it'll take me to novu.co

Also I've an idea we can add novu.co in footer's logo as well add the link in the footer where copyrights reserved written

PritamSarbajna avatar Aug 14 '22 19:08 PritamSarbajna

I think we can navigate the bottom logo to nove.co as a new tab. And for now we can skip the additional link as you suggested. @scopsy any thoughts here?

ComBarnea avatar Aug 15 '22 05:08 ComBarnea

Hey @ComBarnea I was not asking for adding a extra link with extra area. I was just asking if we click on this copyright area's words we can also add a link to novu.co

Presentation1

PritamSarbajna avatar Aug 15 '22 09:08 PritamSarbajna

@ComBarnea and also this is is a issue for novu website why you transferred it to this repo ?

PritamSarbajna avatar Aug 15 '22 09:08 PritamSarbajna

@PritamSarbajna our docs are managed in our main repo, and not on the website repo. And while we were discussing our design team updated the logo to include documentation. Screen Shot 2022-08-15 at 13 37 26

I think that adding another column with a Home link would be the best option, as clicking on the copyright area is very unusual.

Happy to jump on a call over our discord if that could help :)

ComBarnea avatar Aug 15 '22 10:08 ComBarnea

Yeah sure @ComBarnea. Now we can't add novu.co into the logo. Okay so you're saying make another column not another row ?

PritamSarbajna avatar Aug 15 '22 10:08 PritamSarbajna

I think just adding another row on the existing columng with work there :)

scopsy avatar Aug 15 '22 11:08 scopsy

Hi @PritamSarbajna You need any help to implement this? Feel free to ask in discord! https://discord.com/channels/895029566685462578/1019663407915483176

jainpawan21 avatar Oct 07 '22 16:10 jainpawan21

Hi @PritamSarbajna did you had a chance to look at it?

scopsy avatar Nov 27 '22 13:11 scopsy

Hi @PritamSarbajna did you had a chance to look at it?

Sorry @scopsy I tried but I couldn't run this locally probably I should learn more.

PritamSarbajna avatar Nov 27 '22 13:11 PritamSarbajna

Hi @scopsy and @ComBarnea

I would like to work on this feature. Can you please assign this to me?

Here is my understanding regarding about this feature

  • We need a way to redirect from docs.novu.co to novu.co
  • Proposed solution is to add a new row as Home which can redirect to novu.co
  • This link will open novu.co in a new tab
  • This row will be add to the first column as the first link i.e. above documentation

image

vishnu-kyatannawar avatar Jan 18 '23 20:01 vishnu-kyatannawar

Thanks @jainpawan21

I have opened a PR https://github.com/novuhq/novu/pull/2528 to address this this.

vishnu-kyatannawar avatar Jan 19 '23 11:01 vishnu-kyatannawar