novu
novu copied to clipboard
Replace moment.js with something lighter in the React notification center component
More info: https://github.com/novuhq/novu/pull/854#issuecomment-1192069233
@scopsy, @davidsoderberg
So will date-fns
work or any other library needs to be used?
Also, assign this to me.
@BiswaViraj I think date-fns
will be great, assigning 🙏
@BiswaViraj dayjs would be more good choice vs date-fns.
I could see date-fns takes about 100kb in minified version whereas days used only around 6kb minified version.
Cc: @scopsy
Is this issue still open?
@BiswaViraj did you had a chance to start working on this? If not, let me know and I can assign @crismxiex for this one 🙏
@scopsy , I've just done the bare minimum setup for it, been traveling this week, so I'm not able to get back to it till Saturday or Sunday when I reach home. I'm fine with @crismxiex working on this, if he is interested.
@BiswaViraj Apologize I was checking on the phone and I missed this issue was already assigned.
No worries @crismxiex just assigned you for this one 🚀
@scopsy just to double check, the change should be to date-fns?
Yes 🙏
Sorry @crismxiex looks like it was already implemented at #1032