novu icon indicating copy to clipboard operation
novu copied to clipboard

Replace moment.js with something lighter in the React notification center component

Open WinterCore opened this issue 2 years ago • 8 comments

More info: https://github.com/novuhq/novu/pull/854#issuecomment-1192069233

WinterCore avatar Jul 25 '22 13:07 WinterCore

@scopsy, @davidsoderberg

So will date-fns work or any other library needs to be used? Also, assign this to me.

BiswaViraj avatar Aug 03 '22 15:08 BiswaViraj

@BiswaViraj I think date-fns will be great, assigning 🙏

scopsy avatar Aug 03 '22 15:08 scopsy

@BiswaViraj dayjs would be more good choice vs date-fns.

I could see date-fns takes about 100kb in minified version whereas days used only around 6kb minified version.

Cc: @scopsy

aggmoulik avatar Aug 04 '22 22:08 aggmoulik

Is this issue still open?

crismxiex avatar Aug 09 '22 17:08 crismxiex

@BiswaViraj did you had a chance to start working on this? If not, let me know and I can assign @crismxiex for this one 🙏

scopsy avatar Aug 09 '22 17:08 scopsy

@scopsy , I've just done the bare minimum setup for it, been traveling this week, so I'm not able to get back to it till Saturday or Sunday when I reach home. I'm fine with @crismxiex working on this, if he is interested.

BiswaViraj avatar Aug 09 '22 17:08 BiswaViraj

@BiswaViraj Apologize I was checking on the phone and I missed this issue was already assigned.

crismxiex avatar Aug 09 '22 18:08 crismxiex

No worries @crismxiex just assigned you for this one 🚀

scopsy avatar Aug 12 '22 09:08 scopsy

@scopsy just to double check, the change should be to date-fns?

crismxiex avatar Aug 12 '22 15:08 crismxiex

Yes 🙏

scopsy avatar Aug 12 '22 15:08 scopsy

Sorry @crismxiex looks like it was already implemented at #1032

scopsy avatar Aug 17 '22 14:08 scopsy