novuhq
fix(api): remove environment id from get integration
What changed? Why was the change needed?
When user is in development environment and go to production sendgrid integration, webhook URL is not showing because at API level, _environmentId is still development one and integration is not found in development env. Above case can be reproducesd for development integrations in the production environment.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer
Does the environment come from the Novu-Environment-Id http header? Since we have separate integrations per environment, shouldn't the environment be set regardless but not from the header?
environmentId comes with user session. Production integrations can be accessed from the development environment.
https://github.com/user-attachments/assets/9420674a-639d-48d8-a498-b766fa25bb4d
Deploy Preview for novu-stg-vite-dashboard-poc ready!
| Name | Link |
|---|---|
| Latest commit | 09b27c17123768392f3b1563b7cbed26134df656 |
| Latest deploy log | https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/671689f9886d7a0008c28ff1 |
| Deploy Preview | https://deploy-preview-6493--novu-stg-vite-dashboard-poc.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for dev-web-novu ready!
| Name | Link |
|---|---|
| Latest commit | 3eae7d4e38b7c55b3455a9ff7e46ec4207893e82 |
| Latest deploy log | https://app.netlify.com/sites/dev-web-novu/deploys/675ff4c8f2f22a0008323a12 |
| Deploy Preview | https://deploy-preview-6493.dashboard.novu-staging.co |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for dashboard-v2-novu-staging ready!
| Name | Link |
|---|---|
| Latest commit | 3eae7d4e38b7c55b3455a9ff7e46ec4207893e82 |
| Latest deploy log | https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/675ff4c8dec8ed000869e686 |
| Deploy Preview | https://deploy-preview-6493.dashboard-v2.novu-staging.co |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.