novu icon indicating copy to clipboard operation
novu copied to clipboard

chore(application-generic): removed docker version & added healthchecks

Open twentyone24 opened this issue 6 months ago • 0 comments

What changed? Why was the change needed?

  1. Removed version as it's deprecated:

    • The version field is no longer needed in Docker Compose files as it's deprecated, according to the official Compose spec. By removing it, preventing obsolete warnings and ensuring future compatibility with the latest Docker Compose standards.
  2. Added healthchecks for containers and updated dependencies:

    • Adding health checks improves the reliability of services by allowing Docker to ensure that services are healthy and running as expected. This change ensures that dependent services (like api, worker, and ws) only start after the health checks of their dependent services (like mongodb and redis) pass successfully. This avoids race conditions where services might try to connect to others before they're fully ready.

 ~  docker ps
CONTAINER ID   IMAGE                               COMMAND                  CREATED         STATUS                        PORTS                      NAMES
daa4ab35373a   ghcr.io/novuhq/novu/embed:0.24.0    "docker-entrypoint.s…"   2 minutes ago   Up 50 seconds (healthy)       0.0.0.0:4701->4701/tcp     embed
5aa0298cbc9f   ghcr.io/novuhq/novu/widget:0.24.0   "docker-entrypoint.s…"   2 minutes ago   Up About a minute (healthy)   0.0.0.0:4500->4500/tcp     widget
b506e29ce4cb   ghcr.io/novuhq/novu/web:0.24.0      "docker-entrypoint.s…"   2 minutes ago   Up About a minute (healthy)   0.0.0.0:4200->4200/tcp     web
9de5ebda5cf5   ghcr.io/novuhq/novu/worker:0.24.0   "docker-entrypoint.s…"   2 minutes ago   Up About a minute (healthy)                              worker
2bfc922f6300   ghcr.io/novuhq/novu/ws:0.24.0       "docker-entrypoint.s…"   2 minutes ago   Up About a minute (healthy)   0.0.0.0:3002->3002/tcp     ws
8f7f7d035da7   ghcr.io/novuhq/novu/api:0.24.0      "docker-entrypoint.s…"   2 minutes ago   Up About a minute (healthy)   0.0.0.0:3000->3000/tcp     api
9b88fe95bae7   mongo                               "docker-entrypoint.s…"   2 minutes ago   Up 2 minutes (healthy)        0.0.0.0:27017->27017/tcp   mongodb
a307275d4b8b   redis:alpine                        "docker-entrypoint.s…"   2 minutes ago   Up 2 minutes (healthy)        6379/tcp                   redis
Screenshot

image


Thanks for taking your time reviewing this :D

twentyone24 avatar Aug 24 '24 17:08 twentyone24