novu
novu copied to clipboard
Published
20 hours ago •
novuhq
novuhq
Nv 2906 remove the is topic notification enabled feature flag
What changed? Why was the change needed?
A feature flag that is always set to true has been removed, along with all associated 'false' code paths. Additionally, dead code was also removed and used helpers moved to more appropriate places
Special notes for your reviewer
I've placed 2 options in this MR and we should agree on what option we want to use. I'm leaning more towards Option 1 as it complains right away, not only when tests are run. Option 2 also seems a bit ugly, but that is more personal preference.
![linear[bot] avatar](https://avatars.githubusercontent.com/in/20150?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for novu-design ready!
| Name | Link |
|---|---|
| Latest commit | f294347a1290ab6bdea379b837ad69eaafc4b1cf |
| Latest deploy log | https://app.netlify.com/sites/novu-design/deploys/6639e005567cee0008a5ec6e |
| Deploy Preview | https://deploy-preview-5493--novu-design.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for dev-web-novu ready!
| Name | Link |
|---|---|
| Latest commit | f294347a1290ab6bdea379b837ad69eaafc4b1cf |
| Latest deploy log | https://app.netlify.com/sites/dev-web-novu/deploys/6639e0054ac3d100087106fd |
| Deploy Preview | https://deploy-preview-5493--dev-web-novu.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.