novu
novu copied to clipboard
✨ Polishing: avoid react and react dom as dependencies for notification-center-vue
📜 Description
When pulling notification-center-vue
in a Vue/Nuxt project, the react
and react-dom
dependencies should be "devDependencies". notification-center
seems to only have react
and react-dom
as devDependencies
as well.
This also conflicts with other potential third-party packages that have react
as a peer dependency (like @vercel/analytics
, forcing the use of --legacy-peer-deps
flag or the overrides
property in package.json
.
👟 Reproduction steps
- Install
notification-center-vue
in any vue project with@vercel/analytics
- Notice the mismatch in version
👍 Expected behavior
It should not have react
and react-dom
listed as dependencies, but maybe devDependencies or peerDepencencies instead.
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
🏢 Have you read the Contributing Guidelines?
- [X] I have read the Contributing Guidelines
Related: https://github.com/novuhq/vue-quickstart/issues/2