novu icon indicating copy to clipboard operation
novu copied to clipboard

Published 20 hours ago • verified publisher icon novuhq

fix(provider): add better proxy support for brevo mail provider

Open nohira opened this issue 1 year ago • 2 comments

What change does this PR introduce?

Add better proxy for brevo mail provider as axios may leads to 502 error when having proxy over HTTPS

Why was this change needed?

Using actual provider leads to 502 error (Squid proxy error with zero size reply) as axios have some issues with HTTPS over proxy.

Other information (Screenshots)

Using cross-fetch with proxy-agent to have better proxy management

nohira avatar Jan 10 '24 13:01 nohira

Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
Latest commit cce931da548a5213dd319cfafbb5afcbca46bc16

netlify[bot] avatar Jan 17 '24 09:01 netlify[bot]

Is it possible to have this fix in the next release? I know it involve a provider that may be already productive, but there is an issue with axios and some proxies over https calls:

https://github.com/axios/axios/issues/5078

I'm on an on premise that involve a proxy for external calls

nohira avatar Jan 30 '24 07:01 nohira

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Apr 07 '24 16:04 github-actions[bot]