novu icon indicating copy to clipboard operation
novu copied to clipboard

fix: Subscriber property

Open nick2432 opened this issue 1 year ago • 4 comments

What change does this PR introduce?

Basically, I updated the POST request code and sent firstName, lastName, and email in the request.

Why was this change needed?

Closes https://github.com/novuhq/novu/issues/4096

Other information (Screenshots)

before Screenshot from 2023-11-13 09-57-43

after Screenshot from 2023-11-12 12-30-57

nick2432 avatar Nov 13 '23 04:11 nick2432

@nick2432 I think we should add other properties like phone, locale and data as well

jainpawan21 avatar Nov 30 '23 15:11 jainpawan21

@nick2432 I think we should add other properties like phone, locale and data as well

If my code implementation is correct, then I will add other properties as well. Could you please check the implementation

nick2432 avatar Nov 30 '23 15:11 nick2432

Implementation seems to be correct

jainpawan21 avatar Dec 01 '23 05:12 jainpawan21

Implementation seems to be correct

ok i will add other properties

nick2432 avatar Dec 01 '23 05:12 nick2432

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Apr 07 '24 16:04 github-actions[bot]