novu
novu copied to clipboard
[NV-1367] (JS-0050) Avoid use of == and != issue#2287
What change does this PR introduce?
This PR solved the issue of [NV-1367] (JS-0050) Avoid use of == and != issue #2287
Why was this change needed?
As it is a good practice in the modern day to use the === & !== instead of the == & != it strengthens the security of the code base
Other information (Screenshots)
As these were some of the issues which have been solved
reverted those 2 files kindly check https://github.com/novuhq/novu/pull/2292/commits/3e4304b34a8ac98ea6b7424c7b9bbd09bcc2d9cb
Might have solved the 1=='1'
issue, can you check that again, please?
It might be helpful if you can tell me where I can run tests before submitting the code, Thanks
@djabarovgeorge removed the function from the code & checked there were no imports related to the function. https://github.com/novuhq/novu/pull/2292/commits/0ca668b7664d0047995d3bf6ba9f2959c13ac9f5
@ShashwatAgrawal20 sorry for the confusion but let's bring it back in the old format in case some other old API users still rely on that. We will deprecate this properly over the next couple of releases
@scopsy should I close the PR?
@ShashwatAgrawal20 could you just revery the thing I mentioned so we can merge this? :)
@scopsy did the changes where I was unsure & keep those strict checks where I thought this should not create any issue & also removed the function initializeSeenParam()
which is not being used anymore.