novu icon indicating copy to clipboard operation
novu copied to clipboard

[NV-1370] (JS-0042) Found no return statements in callbacks of array methods

Open scopsy opened this issue 2 years ago • 1 comments

Description

Array has several methods for filtering, mapping, and folding. If we forget to write return statement in a callback of those, it's probably a mistake. If you don't want to use a return or don't need the returned results, consider using .forEach instead.

Occurrences

There are 3 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/novuhq/novu/issue/JS-0042/occurrences/

NV-1370

scopsy avatar Dec 15 '22 12:12 scopsy

@scopsy I'd like to work on the issue if possible

ShashwatAgrawal20 avatar Dec 15 '22 17:12 ShashwatAgrawal20

@scopsy it seems that the issue has been fixed?? Maybe with some other commits? When I check the deepsource URL, the page says can't find any occurrence of this issue.

Can you please confirm 🙇

bsantosh909 avatar Jan 08 '23 02:01 bsantosh909

Yes i think it is fixed

jainpawan21 avatar Jan 08 '23 08:01 jainpawan21