novu icon indicating copy to clipboard operation
novu copied to clipboard

Published 20 hours ago • verified publisher icon novuhq

Add fcm data messages (#2007)

Open raikasdev opened this issue 1 year ago • 6 comments

What change does this PR introduce?

Adds possibility to send data notifications with FCM

Why was this change needed?

Closes #2007

raikasdev avatar Nov 30 '22 14:11 raikasdev

@raikasdev thanks for the PR! 🔥 just left you a small question...

LetItRock avatar Dec 05 '22 16:12 LetItRock

@raikasdev hey, how's it going? any chance that you can take a look at my suggestions?

LetItRock avatar Dec 13 '22 12:12 LetItRock

Hey! I'm doing the suggestions now. Have been busy with schoolwork and youth council meetings.

raikasdev avatar Dec 15 '22 15:12 raikasdev

Suggestions done

raikasdev avatar Dec 18 '22 14:12 raikasdev

Where we able to solve this? Would be so appreciated! Can I assist on making the test pass?

viktorlarsson avatar Dec 30 '22 10:12 viktorlarsson

@viktorlarsson will make sure to merge it for the patch release will probably be released tomorrow already

scopsy avatar Jan 02 '23 16:01 scopsy