novu
novu copied to clipboard
novuhq
New Provider - Microsoft Outlook365
What change does this PR introduce?
Creates a new email provider for Microsoft Outlook 360.
Why was this change needed?
Microsoft Outlook requires specific settings such as server, port, and TLS settings. To make it easier on new users coming to the platform to connect up to Outlook 365
Other information (Screenshots)
I double checked, and the local pnpm-lock.yaml is updated, not sure how to fix that one.
pnpm-lock.yamlis updated, not sure how to fix that one.
There has been some updates to the dependencies and your branch is out of date. You can merge the latest version of next or to rebase your PR onto it. I can help you with the second if you can't fix it by yourself.
@p-fernandez rebase / merge complete. that was more difficult than I thought it would be for some reason lol
@p-fernandez rebase / merge complete. that was more difficult than I thought it would be for some reason lol
Let me help you as you have multiple conflicts.
@cryptic-ai I made a mistake when pushing the fixes to your fork and deleted your work but I still have it in my local. Can you give me permissions of collaborator in your repo?
Hello @cryptic-ai , awesome work 🔥, could you look into the failing tests so that we can merge it soon 💪
Hey, @BiswaViraj latest fix has been sent up! The tests are passing locally. I also added the outlook365 package to the code-workspace file as well.
@p-fernandez fixed the tests (thanks for your help on that!). Looks like I'm getting merge conflicts again. For some reason it's not letting me rebase locally. Would it be best if we closed this PR, and I just commit a new PR from a remote branch that's not a next clone to get rid of these issues?
@p-fernandez fixed the tests (thanks for your help on that!). Looks like I'm getting merge conflicts again. For some reason it's not letting me rebase locally. Would it be best if we closed this PR, and I just commit a new PR from a remote branch that's not a
nextclone to get rid of these issues?
Just give me 5 minutes as I am trying to do the rebase for you in my local.
@p-fernandez fixed the tests (thanks for your help on that!). Looks like I'm getting merge conflicts again. For some reason it's not letting me rebase locally. Would it be best if we closed this PR, and I just commit a new PR from a remote branch that's not a
nextclone to get rid of these issues?Just give me 5 minutes as I am trying to do the rebase for you in my local.
I need to help one of my teammates. Would you mind to do what you suggested? Sorry for the hassles. 🙏🏻
@
@p-fernandez fixed the tests (thanks for your help on that!). Looks like I'm getting merge conflicts again. For some reason it's not letting me rebase locally. Would it be best if we closed this PR, and I just commit a new PR from a remote branch that's not a
nextclone to get rid of these issues?Just give me 5 minutes as I am trying to do the rebase for you in my local.
I need to help one of my teammates. Would you mind to do what you suggested? Sorry for the hassles. 🙏🏻
Yeah no worries! I'll get this done sometime today :)