novu
novu copied to clipboard
novuhq
feat: utilize entire screen height on workflow editor
What change does this PR introduce?
This change will make workflow editor to utilize more screen height
Why was this change needed?
Closes #666
Other information (Screenshots)
I see no problems in this but what do you think about this improvement? @LetItRock @ainouzgali
@Ian-Yy @p-fernandez
I think that we should improve this a little more if we want to utilize all the available space. The value 85vh is not an ideal solution because it might look good on some screens, but won't do the job for ex. for bigger ones.
What I would suggest is to do something like this: calc(100vh - ${HEADER_HEIGHT}px - 60px) instead, where the HEADER_HEIGHT is the constant extracted from the height property (65px) of <Header component in the HeaderNav.tsx file. The 60px is a doubled padding around the AppShell unfortunately it comes from the Mantine.
This will solve the issue on bigger screens.
However it doesn't look good on the smallest ones that we support (1280x700), but it's a different story and it's the current state.
Sorry for taking quite some time for this. Was quite occupied recently. Nevertheless, here's the changes as commented. Please let me know if anything else is needed.
Looks good to me. @LetItRock is this change ok? If so, let's merge it. 🙂
@p-fernandez looks good to me ;)
@Ian-Yy thanks a lot for your contribution! you rock! 🔥