novu icon indicating copy to clipboard operation
novu copied to clipboard

Published 20 hours ago • verified publisher icon novuhq

Add notification group endpoints

Open deepak-sreekumar opened this issue 2 years ago • 7 comments

What kind of change does this PR introduce?

Added Notification group endpoints

  • GET /v1/notification-groups/:id

  • PUT /v1/notification-groups/:id

  • DELETE /v1/notification-groups/:id

  • [ ] Bug

  • [x] Feature

  • [ ] Docs

  • [ ] Other(s)

Why was this change needed?

#1321

Other information (Screenshots)

deepak-sreekumar avatar Oct 30 '22 17:10 deepak-sreekumar

I wish I could review this but I am not familiar enough with the api codebase cc @scopsy

florian-lefebvre avatar Oct 30 '22 19:10 florian-lefebvre

Thanks for the review @p-fernandez ! I'll try and resolve the comments In a day or two.

deepak-sreekumar avatar Nov 02 '22 04:11 deepak-sreekumar

Hi @deepak-sreekumar did you had a chance to take a look at @p-fernandez comments here?

scopsy avatar Nov 14 '22 06:11 scopsy

Hi @scopsy, Really sorry but I did not get a chance to address the comments yet! Let me try to spend some time on this over this weekend.

deepak-sreekumar avatar Nov 17 '22 03:11 deepak-sreekumar

Hey @deepak-sreekumar any news on this?

florian-lefebvre avatar Dec 05 '22 10:12 florian-lefebvre

@scopsy / @p-fernandez Addressed the PR comments. Please take a look when you get time! Really sorry about the delay here. Got caught up with some urgent stuff. (This might be the case for next month as well so I'll most likely won't be able to address the comments right away but I'll try my best! :( . )

deepak-sreekumar avatar Dec 05 '22 16:12 deepak-sreekumar

@deepak-sreekumar do you need help in resolving PR comments. Feel free to ask us in discord

jainpawan21 avatar Jan 02 '23 02:01 jainpawan21

Closing this PR due to inactivity and new PR by @peoray

jainpawan21 avatar Apr 29 '23 16:04 jainpawan21