novu icon indicating copy to clipboard operation
novu copied to clipboard

Greet first-time contributors in Novu repository

Open MrKrishnaAgarwal opened this issue 2 years ago • 9 comments

Signed-off-by: Krishna Agarwal [email protected]

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature: The Welcome Bot Greets first-time contributors.

  • Other information:

This will greet the first-time contributors with a welcome message:

  • When they open their first PR
  • When they open their first issue

This will not greet the contributors who have already contributed to the project. This will also not greet the contributors who have already been greeted by the bot.

This will help in reducing the notification chaos and will help in welcoming the first-time contributors.

cc @scopsy

MrKrishnaAgarwal avatar Oct 29 '22 15:10 MrKrishnaAgarwal

Please remember to install the Welcome Bot app on the repo so that it can work else it will not work. Here is the link: https://probot.github.io/apps/welcome - Verified by GitHub

MrKrishnaAgarwal avatar Oct 29 '22 15:10 MrKrishnaAgarwal

@ainouzgali How's the idea?

MrKrishnaAgarwal avatar Oct 30 '22 17:10 MrKrishnaAgarwal

I remember it was discussed previously and we decided against it here. Is the difference now that it is only for first-time contributors?

ainouzgali avatar Oct 31 '22 10:10 ainouzgali

Please see now, I think it's fine :)

MrKrishnaAgarwal avatar Oct 31 '22 11:10 MrKrishnaAgarwal

Note:

This bot will only greet first-time contributors You can read more details above ☝🏻

MrKrishnaAgarwal avatar Oct 31 '22 11:10 MrKrishnaAgarwal

I remember it was discussed previously and we decided against it here. Is the difference now that it is only for first-time contributors?

Yes! But it's not a github action

MrKrishnaAgarwal avatar Oct 31 '22 14:10 MrKrishnaAgarwal

Ok. I would still like @scopsy's input here. But I'll add the hacktoberfest-accepted label, so it will still count for you in case he can't today.

ainouzgali avatar Oct 31 '22 14:10 ainouzgali

Ok. I would still like @scopsy's input here. But I'll add the hacktoberfest-accepted label, so it will still count for you in case he can't today.

Okay, Thanks

FunFact: I already qualified for DigitalOcean Hacktoberfest a long ago... i.e. On 7th Oct 🙂

image

:)

MrKrishnaAgarwal avatar Oct 31 '22 14:10 MrKrishnaAgarwal

@ainouzgali any updates please?

MrKrishnaAgarwal avatar Nov 08 '22 07:11 MrKrishnaAgarwal

I tend to aggree with @ainouzgali that it's hard to see any particular value with current behaviour. Another concern I have is the robot implementation welcome seems like a very small repo with not a lot of traction, and it requires a read and write permissions for PR's. From security standpoint I would skip the usage of this action, perhaps in the future we might look at other automation for such task.

Thank you @MrKrishnaAgarwal for your contribution nonetheless 🙏

scopsy avatar Nov 14 '22 06:11 scopsy