novu icon indicating copy to clipboard operation
novu copied to clipboard

🚀 Feature: Building up Pushwoosh

Open CursedRock17 opened this issue 2 years ago • 3 comments

🔖 Feature description

Currently the Pushwoosh Push provider is very low built and not up to par with the other services while it could be.

🎤 Why is this feature needed ?

When looking through the documentation I noticed there were many more modes to the studying sent messages and sending messages that come straight out the box with Pushwoosh. Pushwoosh is a very dynamic push provider that doesn't have a main purpose of sending messages, but sending responses on certain signals of receiving a push notification which makes it contrast it's fellow push proivders.

✌️ How do you aim to achieve this?

The best to achieve this is to mess around with the architecture of the Novu push provider base class and allow modularity to what this needs. Mainly, the base function should create a monitor based on the constructor gives, then the extended class would contain many smaller functions that are encapsulated in a larger, main function. This function could use a hash map effect to link commands to the encapsulated functions and call it depending the on the user's end goal.

🔄️ Additional Information

I have already put it push request #1876 to create the base structure for the Pushwoosh provider. Once this provider gets merged to the main branch this work can begin as it is very far behind the other providers.

👀 Have you spent some time to check if this feature request has been raised before?

  • [X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

No response

CursedRock17 avatar Oct 29 '22 06:10 CursedRock17

Here's the pull request I already sent in, once it gets merged you can use that as a tool #1876

CursedRock17 avatar Oct 29 '22 13:10 CursedRock17

@scopsy Hey, is this issue still valid? I'm eager to help with this, I'm new to this project so please let me know how I can get started. Thanks!

DarhkVoyd avatar Oct 01 '23 08:10 DarhkVoyd

Hi @scopsy and Novu team,

I noticed that the integration of the Pushwoosh provider is still open and the last PR was closed. I've reviewed the requirements and previous discussions, and I am interested in taking this on. If there are any specific guidelines or insights you'd like to share before I start, please let me know. Looking forward to contributing to this great project!

Best regards, Anton Gorbachev.

1Gluk1 avatar Dec 23 '23 09:12 1Gluk1