novu
novu copied to clipboard
🐛 Bug Report: on not exposed in embed.js
📜 Description
Listening to action_click
or notification_click
events is not possible via iframe due to a missing function on
.
👟 Reproduction steps
- Include embed.js
- Initialize Novu
- Use the on function
👍 Expected behavior
It should listen to *_click events
👎 Actual Behavior with Screenshots
Throws an undefined function error
💻 Operating system
MacOS
🤖 Node Version
Latest Docker Image
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
🏢 Have you read the Contributing Guidelines?
- [X] I have read the Contributing Guidelines
Are you willing to submit PR?
No response
@JustinBack May I take this?
@JustinBack May I take this?
Sure, I cannot find time to work on this particular issue
Hi @vedant-z Are you interested to work on this?
@jainpawan21 Ya sure. I just need some help on how should I approach this 😃
Hi @vedant-z I think it would be best to request help over our discord regarding this. Did you had a chance to have any progress on this?
@LetItRock, Is this issue fixed in one of your recent PR related to NC and embed?
@jainpawan21 from a test i made this is still haven't been exposed.
novu.on
is working for me now
can we close this issue? @scopsy