novu icon indicating copy to clipboard operation
novu copied to clipboard

🐛 Bug Report: on not exposed in embed.js

Open JustinBack opened this issue 2 years ago • 6 comments

📜 Description

Listening to action_click or notification_click events is not possible via iframe due to a missing function on.

👟 Reproduction steps

  1. Include embed.js
  2. Initialize Novu
  3. Use the on function

👍 Expected behavior

It should listen to *_click events

👎 Actual Behavior with Screenshots

Throws an undefined function error DA700480-9489-41D2-BD6C-C85A6FD4D800 B33DF557-1271-47BA-B8F4-FF1C0B39943E

💻 Operating system

MacOS

🤖 Node Version

Latest Docker Image

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • [X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

No response

JustinBack avatar Oct 20 '22 06:10 JustinBack

@JustinBack May I take this?

vedant-z avatar Oct 25 '22 08:10 vedant-z

@JustinBack May I take this?

Sure, I cannot find time to work on this particular issue

JustinBack avatar Oct 25 '22 09:10 JustinBack

Hi @vedant-z Are you interested to work on this?

jainpawan21 avatar Oct 26 '22 16:10 jainpawan21

@jainpawan21 Ya sure. I just need some help on how should I approach this 😃

vedant-z avatar Oct 27 '22 02:10 vedant-z

Hi @vedant-z I think it would be best to request help over our discord regarding this. Did you had a chance to have any progress on this?

scopsy avatar Nov 27 '22 12:11 scopsy

@LetItRock, Is this issue fixed in one of your recent PR related to NC and embed?

jainpawan21 avatar Dec 21 '22 06:12 jainpawan21

@jainpawan21 from a test i made this is still haven't been exposed.

scopsy avatar May 07 '23 14:05 scopsy

novu.on is working for me now

can we close this issue? @scopsy

jainpawan21 avatar Aug 29 '23 09:08 jainpawan21