novu fix(web): fixed every selected image upload on aws bug

fix(web): fixed every selected image upload on aws bug

Open devblin opened this issue 2 years ago • 7 comments

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fixes issue of every chosen image upload on aws-s3.
Why was this change needed? (You can also link to an open issue here) #829

Oct 08 '22 06:10 devblin

@scopsy please review

Oct 08 '22 06:10 devblin

@devblin would be great if we could do some test to prevent this bug in the future 😄

Oct 08 '22 07:10 davidsoderberg

@davidsoderberg I have tested this fix locally and it looks good.

Oct 08 '22 10:10 devblin

@devblin could some automatic tests be done for this?

Oct 08 '22 10:10 davidsoderberg

@davidsoderberg , You mean adding tests in apps/web/cypress/tests right ?

Oct 08 '22 10:10 devblin

Yes if there is a way to interact with it in the frontend it would be great :)

Oct 08 '22 12:10 davidsoderberg

@devblin seems like this is breaking the current tests :( Will you have time to take a look at this?

Nov 20 '22 13:11 scopsy

Closing this for now due to inactivity, we can re open once the tests are passing 🙏

Dec 11 '22 03:12 scopsy