novu icon indicating copy to clipboard operation
novu copied to clipboard

Published 20 hours ago • verified publisher icon novuhq

[NV-929] - Add cypress component test to NavMenu component

Open novubot opened this issue 1 year ago • 10 comments

Why?

To help increase our test coverage within the novu/web project, we can add the newly released cypress component tests.

How?

A new component test file should be added located near the original source file(see example at apps/web/src/design-system/button/button.cy.tsx and could be run after running npm run start from the root of the monorepo and specifying "Run Tests" and "Open Cypress", after which select the "Component testing" in the cypress screen.

Write the new test and make sure it passes all assertions.

The component is located at: apps/web/src/design-system/navigation/NavMenu.tsx

novubot avatar Oct 05 '22 13:10 novubot

Hello, Can you assign this Issue to me?

mstomar698 avatar Oct 05 '22 17:10 mstomar698

Hi @mstomar698 I've already assigned you to a different issue. Unfortuently we don't allow more than one open assignment at this point.

Thank you so much for your support and contribution!

scopsy avatar Oct 05 '22 23:10 scopsy

I would like to work on this issue. Can you please assign this to me? @scopsy

shikhar13012001 avatar Oct 06 '22 02:10 shikhar13012001

@scopsy If you want I can work on this

ludovicobesana avatar Oct 07 '22 21:10 ludovicobesana

@scopsy I'm working on this :)

ludovicobesana avatar Oct 08 '22 15:10 ludovicobesana

@shikhar13012001 Are you working on this? If not, Please let us know

jainpawan21 avatar Oct 11 '22 14:10 jainpawan21

I am interested to solve this issue, so can you assign me ?

soundarrajan-official avatar Oct 14 '22 16:10 soundarrajan-official

any update on this issue? if not I would like to take

chaiwattsw avatar Oct 16 '22 07:10 chaiwattsw

@ludovicobesana did you managed to complete this? assigned you, let me know if I should assign some one else 🙏

scopsy avatar Oct 16 '22 08:10 scopsy

I'm working on it. I'm returning back on Italy on 18 october.

Il Dom 16 Ott 2022, 09:32 Dima Grossman @.***> ha scritto:

@ludovicobesana https://github.com/ludovicobesana did you managed to complete this? assigned you, let me know if I should assign some one else 🙏

— Reply to this email directly, view it on GitHub https://github.com/novuhq/novu/issues/1456#issuecomment-1279921278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILJSHYJDDTJWAF7OULDQXTWDO4R3ANCNFSM6AAAAAAQ5ST7LU . You are receiving this because you were mentioned.Message ID: @.***>

ludovicobesana avatar Oct 16 '22 08:10 ludovicobesana

@scopsy I see that @chaiwattsw have submitted already a pr. If it's good you can assign this issue to him.

ludovicobesana avatar Oct 24 '22 22:10 ludovicobesana