novu icon indicating copy to clipboard operation
novu copied to clipboard

feat: add mark all as read functionality

Open jainpawan21 opened this issue 2 years ago • 1 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) feature: This pr adds mark all as read functionality in notification-center
  • What is the current behavior? (You can also link to an open issue here) #955
  • What is the new behavior (if this is a feature change)? Mark all as read functionality is working ✅
  • Other information:

jainpawan21 avatar Aug 11 '22 16:08 jainpawan21

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 2:53PM (UTC)

vercel[bot] avatar Aug 11 '22 16:08 vercel[bot]

@jainpawan21 i've merged changes from the release branch and we have added a cog functionality there. Could you take a look at the current state of the UI? we might need to modify it a bit. Also when it comes to the feeds support worth checking out: https://www.figma.com/file/9jalQvImfHtbbExZPLW3XO/Concepting?node-id=2244%3A28064 too. @ainouzgali what do you think?

scopsy avatar Aug 15 '22 11:08 scopsy

@jainpawan21 i've merged changes from the release branch and we have added a cog functionality there. Could you take a look at the current state of the UI? we might need to modify it a bit. Also when it comes to the feeds support worth checking out: https://www.figma.com/file/9jalQvImfHtbbExZPLW3XO/Concepting?node-id=2244%3A28064 too. @ainouzgali what do you think?

Sure @scopsy, I will look into this

jainpawan21 avatar Aug 15 '22 11:08 jainpawan21

@jainpawan21 i've merged changes from the release branch and we have added a cog functionality there. Could you take a look at the current state of the UI? we might need to modify it a bit. Also when it comes to the feeds support worth checking out: https://www.figma.com/file/9jalQvImfHtbbExZPLW3XO/Concepting?node-id=2244%3A28064 too. @ainouzgali what do you think?

Settings icon is missing in mentioned figma design

jainpawan21 avatar Aug 15 '22 12:08 jainpawan21

Thank you @jainpawan21 so much for this one, it's super exciting! Added a couple of comments here. Could you also please provide a small video or images on how this works?

@scopsy, This is how it is working. Unfortunately, real-time updates are not working for me. Relevant issue

https://user-images.githubusercontent.com/39362422/184659172-0758ca95-c99a-4fb3-b089-99db4eb28486.mov

jainpawan21 avatar Aug 15 '22 14:08 jainpawan21

@jainpawan21 I'm checking with our designer about the mark all as seen location if that's ok. And otherwise we can merge :)

scopsy avatar Aug 17 '22 12:08 scopsy

Shall I fix merge conflict?

jainpawan21 avatar Aug 18 '22 18:08 jainpawan21

Hi @scopsy, Shall I raise PR again for main branch as this is closed?

jainpawan21 avatar Aug 19 '22 08:08 jainpawan21

Ohhh I deleted the 0.7.0 branch and Github closed this PR automatically :|| Sorry about that, could you please reopen this against main? @jainpawan21

scopsy avatar Aug 19 '22 08:08 scopsy