Memacs icon indicating copy to clipboard operation
Memacs copied to clipboard

memacs_firefox output does not include url title

Open japhir opened this issue 3 years ago • 7 comments

in https://github.com/novoid/Memacs/issues/87 this issue is mentioned for chrome, and in https://github.com/novoid/Memacs/pull/98 @alex-a-soto fixed the chrome output by including a title url in the note's name.

It would be great if the firefox-backend also did this.

Furthermore it appears that the firefox script is adding a single space before all the lines after the ## -- coding: utf-8 mode: org -- line. I am running the AUR package and wrote the below script to run the package (it gives an error when firefox is running) and fix the first line issue.

#!/usr/bin/sh
pgrep -x firefox >/dev/null && echo "firefox is running" ||
        memacs_firefox -f /home/japhir/.mozilla/firefox/5sm2gv3t.default/places.sqlite | sed 's/^ \*/*/' > /home/japhir/org/memacs/mozhist.org_archive

japhir avatar Dec 01 '20 10:12 japhir

it does look like the line https://github.com/novoid/Memacs/blob/d047c5f87ca106e35248f50cca65ee23dc231e86/memacs/firefox.py#L58 is identical though…

japhir avatar Dec 01 '20 10:12 japhir

There are multiple people who contributed to the Firefox module (and who probably are using it in contrast to me): https://github.com/novoid/Memacs/commits/master/memacs/firefox.py

Does somebody volunteer for this issue? @kidd @nguyenhaiac

novoid avatar Dec 02 '20 19:12 novoid

Unfortunately I'm not using memacs anymore and I'm not sure when I'll have the time to test this up :(

kidd avatar Dec 08 '20 14:12 kidd

I also decided that waiting for several seconds for my agenda to pop up is too annoying as yet, so this feature doesn't have priority for me.

japhir avatar Dec 08 '20 14:12 japhir

I also decided that waiting for several seconds for my agenda to pop up is too annoying as yet, so this feature doesn't have priority for me.

Well, Memacs does not affect your normal agenda performance at all when you generate Memacs data to archive files as described on https://github.com/novoid/Memacs/blob/master/docs/FAQs_and_Best_Practices.org#performance-and-scalability

novoid avatar Dec 08 '20 17:12 novoid

Yes, I know, but for what I would actually use it: to look at what I was doing on a particular day/time, it does slow down the archive view massively. I hadn't realized before looking into this endeavour that your loading times were ~20s ;-)

japhir avatar Dec 09 '20 09:12 japhir

I guess I had the naive view that "they're just a bunch of text files, there's no reason for this to be slow" without realising that the org files are quite complex to parse. I only got a real appreciation for this during the last Emacsconf :).

japhir avatar Dec 09 '20 09:12 japhir