websockify-js icon indicating copy to clipboard operation
websockify-js copied to clipboard

Published 20 hours ago • verified publisher icon novnc

Compatibility with `ws` > 1.0, security issues

Open alexchandel opened this issue 3 years ago • 5 comments

The ws project is now at version 8.2.0. You depend on version 0.4.27. There are lots of intervening security fixes. Are you compatible with ws 8.2.0, or do you depend on the earlier compromised versions?

alexchandel avatar Aug 18 '21 15:08 alexchandel

No idea. This version of websockify isn't really maintained. I suggest you test and see if a newer ws will work.

CendioOssman avatar Sep 20 '21 14:09 CendioOssman

Note that websockify.js crashes with new versions of ws, due to API changes, see #30

alexchandel avatar Dec 28 '21 06:12 alexchandel

If still needed, I made an updated Version that uses all the latest dependencies: https://github.com/saschazesiger/websockify-js-express

saschazesiger avatar Feb 27 '23 18:02 saschazesiger

You are welcome to submit a PR if you have some fixes that you think are appropriate to merge here.

CendioOssman avatar Feb 28 '23 07:02 CendioOssman

Maybe its useful for some but its just my implementation of websockify and doesn't really fit in this repository.. Maybe i'll have time to make a PR soon.

saschazesiger avatar Feb 28 '23 08:02 saschazesiger