NovelRT icon indicating copy to clipboard operation
NovelRT copied to clipboard

libpng: Cannot build with Xcode generator

Open capnkenny opened this issue 2 years ago • 3 comments

https://github.com/glennrp/libpng/issues/344

Until the patch that was PRed for libpng is in, the new build system for Xcode refuses to build libpng and fails. Workaround: Only use ninja or Unix Makefiles generators for now.

Fwiw, there's mention that this issue actually appears on all generators now, but Xcode is the only one that flat-out rejects it.

capnkenny avatar Jun 23 '22 18:06 capnkenny

The alternative is to host a fork of libpng with the fix cherry picked - this would unblock Xcode generation from failing on libpng. However, zlib would also need evaluation as its CMakeLists.txt file is very similar.

capnkenny avatar Jun 23 '22 18:06 capnkenny

Another alternative is that we pull in libpng similar how to this project is doing it: https://github.com/diasurgical/devilutionX/blob/master/3rdParty/libpng/CMakeLists.txt

This appears to build libpng with the ported fix (proposed by the same user) which should unblock this. @RubyNova - any thoughts or concerns here?

capnkenny avatar Jun 23 '22 19:06 capnkenny

If there's a proposed fix that we can reliably target then use that.

Aside from that its up to you.

RubyNova avatar Jun 23 '22 20:06 RubyNova