NovelRT icon indicating copy to clipboard operation
NovelRT copied to clipboard

memcpy_s unavailable on Linux. Defines not working properly.

Open RubyNova opened this issue 3 years ago • 5 comments

As per the title I believe our defines for methods such as memcpy_s are incorrectly placed.

In addition I believ the issue also affects Win32. This is a side effect of us moving away from a centralised header.

What's the best way to handle this?

RubyNova avatar Jan 17 '22 19:01 RubyNova

After a discussion on discord it has been decided we are to remove calls to memcpy_s and other window-specific "secure" versions, and just run validation checks before calling these methods ourselves.

This is not a super complicated fix I don't think, but it is a little involved.

RubyNova avatar May 06 '22 14:05 RubyNova

I'll take care of it.

GooStuffedDoll avatar May 06 '22 21:05 GooStuffedDoll

Ticket is available again. The issue is also relatively simple so not sure why it wasn't marked as a good first issue previously but yeah. Fixed now.

RubyNova avatar Sep 16 '22 18:09 RubyNova

I'll look into this one 😅😅😅

JorchRL avatar Sep 30 '22 17:09 JorchRL

Not heard anything in over a month. Assuming it is abandoned.

RubyNova avatar Nov 08 '22 12:11 RubyNova