parity-signer icon indicating copy to clipboard operation
parity-signer copied to clipboard

Published 20 hours ago • verified publisher icon novasamatech

Confirmation alerts

Open montekki opened this issue 2 years ago • 0 comments

Here the idea was to control all confirmation message from single place. Alert data should have following structure then:

struct Contirm {
  line1: Option<String>
  line2: Option<String>
  yes_message: Option<String>
  no_message: Option<String>
}

Thus UI will default to something like

CONFIRM Are you sure? yes/no

AFAIR this is not really implemented on Rust side yet and many of these alerts are still called by UI. We should clearly change soon that because bugs in those are potential security-related bugs. Not sure if we should already start preparing for this, please create an issue so that we do not forget if postponing.

Originally posted by @Slesarew in https://github.com/paritytech/parity-signer/pull/999#discussion_r868848697

montekki avatar May 10 '22 07:05 montekki