odoo-celery icon indicating copy to clipboard operation
odoo-celery copied to clipboard

Initial upgrade to 17.0

Open Maralai opened this issue 1 year ago • 6 comments

I am working on implementing this celery repo in Odoo 17.0. I found the following issues that either prevented the application from installing or provided a less-than-desirable UI experience.

This may not be comprehensive as:

  • I have not fully implemented the repo.
  • I have not ran the celery_example module.

Maralai avatar Apr 27 '24 20:04 Maralai

This belongs on a new branch.

Maralai avatar Apr 27 '24 20:04 Maralai

@Maralai I just reviewed your PR. Looks good!

However, I don't have time to test this and I don't use the Celery module anymore. The OCA queue_job is just better maintained. Out of curiosity, why do you use this celery module instead of OCA queue_job?

If you can migrate and test with the celery_example module, please do. I'm willingly to merge the PR then.

bobslee avatar Apr 29 '24 07:04 bobslee

I recalled celery from a few years back, and I didn't remember queue_job. I have just implemented queue_job instead, however.

I do have a few projects with celery broker, though not odoo, so I might revisit this someday. But probably won't be for a while.

Thanks!

Maralai avatar Apr 29 '24 08:04 Maralai

Hi there, I did the same and adapted the code for odoo 17 I also sent my pull requests, I had not seen that you had done the same thing I tested with the celery example module and everything seems to work, however I'm not sure of a feature or I looked for an alternative but did not find it : https://github.com/novacode-nl/odoo-celery/pull/46

scwall avatar May 04 '24 19:05 scwall

@Maralai , @scwall please can you review and let me know which PR I should merge? I'm sorry but I don't have any free time for a while, to review/analyse this.

When I get your proposal I will review the final PR and merge. Thanks!

bobslee avatar May 05 '24 13:05 bobslee

Hello, Since I haven't seen an answer from @Maralai , can you create the branch? In my case, everything works, but I'd like to have your opinion on the code concerning the model and the self._cr.after('commit', apply_call_task) part. This no longer exists in the new versions of odoo, so I've done things differently.

scwall avatar May 17 '24 07:05 scwall