kahi-ui
kahi-ui copied to clipboard
novacbn
Bug: Popover
Hey! Thank you for your work on this framework. I have recently started to use into on one of my projects and was very pleased with the documentation and good developer experience.
Since I primarily use Firefox (cause someone's gotta use it) for developing, I noticed that the popover component doesn't work on at least the latest version. It works fine on chrome-based browsers, though is shown all the time on Firefox.
I can't really pin down the reason for the bug, but I will try to look into it.
Cheers, Cobalt
System
- Browser: Mozilla Firefox 78.13.0esr
- OS: Parrot OS 4.11 x86_64 / 5.10.0-8parrot1-amd64 / awesomewm (also not working on Debian plain AFAIK and most likely Ubuntu)
- kahi: @kahi-ui/[email protected] (also not working on official doc page when opening with Firefox)
Thanks for the bug report! Never used ESR before, but normal Firefox on Manjaro (Arch) is my primary so I try to make sure everything works there.
So I downloaded ESR and looked into it. Seems to be :not support for selector lists wasn't until FF 84+ (2020/12/15). It seems to be breaking multiple things not just Popover. I'll look into working around that with postcss-selector-not to flatten the selectors. Just need to test and make everything works there.
Thank you for the quick response and work on finding the bug. Didn't know that ESR lacked this feature compared to stable Firefox.
Did a quick test with the PostCSS plugin. Worked with most Components, but a couple of the multi-part Components had some issues with specificity.
I could probably take another crack at it by breaking out the selectors like .xyz:not(a, b, ...) -> .xyz:not(a), .xyz:not(b). However that's a bit more manual work than just using a plugin. So will be something I'll take a look at in a later date.
In the mean time, updated the Browser Support documentation to reflect the proper minimums.