aos-AVP icon indicating copy to clipboard operation
aos-AVP copied to clipboard

[Bug]: Subtitles not listed for selection during playback

Open JJD2K opened this issue 4 years ago • 1 comments

Problem description

  1. The external subtitle files do not appear in the UP menu -> select subtitle. The files are listed on the INFO page of the movie below the integrated subtitles but are not available for selection during playback. This issue usually happens on videos with multiple integrated subtitles. The file has 32 integrated subtitles - I do not know if the count is not a reason for the issue as on a smaller count of integrated subs the issue is rare.

Please note that there is absolutely no way to load the subtitles even though they are listed as present on the info screen.

This issue is since many versions ago and I reported it previously. Please fix it as it is extremely annoying and it is a KEY feature of the player.

  1. Please make the external subtitles FIRST in the list and loaded by default if present. If one puts external subtitles he obviously wants to use them instead. There is no need to go to the subtitles menu, then scroll through 32 subtitles and select the external ones at the bottom.

Please solve these issues as they are really a KEY part of the application.

Steps to reproduce the issue

I described the steps above - Just use a file with many integrated subtitles and put external subtitles files in the same folder as the video files with the same name as the video file.

If you want screenshots please email me and I will send them to you.

Expected behavior

No response

Your phone/tablet/androidTV model

SONY TV KD-55XD8588

Operating system version

Android TV 7

Application version and app store

No response

Additional system information

No response

Debug logs

No response

JJD2K avatar Apr 14 '22 22:04 JJD2K

I can reproduce with Android 12. (A hopefully) relevant logcat output: 1118 16553 W InputManager-JNI: Input channel object 'a4c8b0f org.courville.nova/com.archos.mediacenter.video.utils.SubtitlesDownloaderActivity (client)' was disposed without first being removed with the input manager!

alvaromartinezmajado avatar May 08 '22 15:05 alvaromartinezmajado

PLEASE fix subtitle issues - these are CORE features and there are issues on 50% of the movies. Please!

JJD2K avatar Jan 16 '23 16:01 JJD2K

@JJD2K thanks for motivating me on this topic...

Current github release (not released on google play yet) I have included the fix discussed here https://github.com/nova-video-player/aos-AVP/issues/643 to allow more subs. I have not checked if this is the reason for not displaying the external subs.

courville avatar Jan 19 '23 21:01 courville

@alvaromartinezmajado thanks for sharing some logcat issue but it seems more related to the subtitles downloader activity while retrieving the subs online.

courville avatar Jan 19 '23 22:01 courville

@JJD2K related to the non selectable subs while playing: this will be the case if the embedded subtitles are PGS subtitles cf. long standing https://github.com/nova-video-player/aos-AVP/issues/47 Do you confirm that this is your case?

PGS embedded subs support is very high on my priority list but will make me deal with parts of the code that I am not really modifying a lot (the C core multimedia engine and ffmpeg).

courville avatar Jan 19 '23 22:01 courville

Hello I do not use the downloader. The issue should not be related to it.

JJD2K avatar Jan 20 '23 11:01 JJD2K

Hello Part one of this issue is fixed: https://github.com/nova-video-player/aos-AVP/issues/802

Please implement point 2 and we can close this issue.

Thank you!

JJD2K avatar May 08 '23 07:05 JJD2K